OCPBUGS-45910: Fix cpu clockspeed for s390x #857
Conversation
openshift-ci
bot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
==========================================
- Coverage 60.54% 60.47% -0.07%
==========================================
Files 75 75
Lines 3992 4003 +11
==========================================
+ Hits 2417 2421 +4
- Misses 1405 1410 +5
- Partials 170 172 +2
|
|
/retest |
2 similar comments
|
/retest |
|
/retest |
apodvrat
force-pushed
the
OCPBUGS_45910_s390x_fix_cpu_clockspeed
branch
from
57ee99b to
bd5c5ec
Compare
|
/retest |
1 similar comment
|
/retest |
apodvrat
force-pushed
the
OCPBUGS_45910_s390x_fix_cpu_clockspeed
branch
from
bd5c5ec to
e7b2a0e
Compare
apodvrat
force-pushed
the
OCPBUGS_45910_s390x_fix_cpu_clockspeed
branch
2 times, most recently
from
603b7ac to
914474f
Compare
|
/retest |
1 similar comment
|
/retest |
|
/override ci/prow/edge-e2e-oci-assisted-4-18 |
|
/override ci/prow/okd-scos-e2e-aws-ovn |
|
/lgtm |
|
@paul-maidment: Overrode contexts on behalf of paul-maidment: ci/prow/edge-e2e-oci-assisted-4-18 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@paul-maidment: Overrode contexts on behalf of paul-maidment: ci/prow/okd-scos-e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apodvrat, paul-maidment The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
|
@paul-maidment: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
apodvrat
changed the title
openshift-ci-robot
added
jira/severity-moderate
|
@apodvrat: This pull request references Jira Issue OCPBUGS-45910, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@apodvrat: This pull request references Jira Issue OCPBUGS-45910, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@apodvrat: This pull request references Jira Issue OCPBUGS-45910, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@apodvrat: This pull request references Jira Issue OCPBUGS-45910, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…del Name Signed-off-by: Amadeus Podvratnik <[email protected]>
apodvrat
force-pushed
the
OCPBUGS_45910_s390x_fix_cpu_clockspeed
branch
from
914474f to
e85a41a
Compare
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/override ci/prow/edge-e2e-oci-assisted-4-18 |
|
@paul-maidment: Overrode contexts on behalf of paul-maidment: ci/prow/edge-e2e-oci-assisted-4-18 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@apodvrat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
@apodvrat: Jira Issue OCPBUGS-45910: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-45910 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.18 |
|
@apodvrat: new pull request created: #888 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-node-agent |
For s390x architectures lscpu does not return the clock speed by "CPU MHz" or "CPU max MHz" field but have two fields (CPU static MHz and CPU dynamic MHz).
"CPU static MHz" is the field representing the designed clock speed whereas the "CPU dynamic MHz" is representing the current CPU speed (throttled or energy saving).
New test case for s390x architecture was added.
In addition the machine type was fixed, too.
The fix was tested using unit tests:
JUnit path was configured: ./junit_unit_test.xml
JUnit report was created: /root/code/Assisted_Installer/latest/assisted-installer-agent/src/inventory/junit_unit_test.xml
Ran 121 of 121 Specs in 0.268 seconds
SUCCESS! -- 121 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestInventory (0.30s)